Let a downloaded update be superseded instead of sticking forever - #123
Merged
Conversation
Two hardenings from a real mid-turn token expiry that presented as a silent session crash: - A Claude turn that dies with an error the auth patterns cannot classify (the SDK's stream diagnostics look nothing like a 401 even when an expired credential caused them) now triggers a rate-limited instance re-probe, so the snapshot flips and the sign-in surface appears in seconds instead of after the next scheduled probe, up to five minutes later. - A Codex error notification marked retryable but reading as an auth failure is now terminal at both layers (adapter event class and session status): retrying cannot heal an expired credential, and the old path burned the app-server's whole reconnect schedule before the sign-in surface appeared.
Once an update reached the downloaded state, every later check was skipped, including the manual menu action, so the ready pill kept advertising whatever it had downloaded even after a newer release shipped or the release it came from was pulled. Checks now run silently in the downloaded state (no checking flicker on the 4-minute poll): a newer version restarts the cycle, the same version leaves the pill untouched, and a feed that no longer offers the update clears it.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
size:M
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the stuck sidebar update pill: once an update was downloaded, every later check (4-minute poll AND the manual menu action) short-circuited on the downloaded state, so the pill advertised its version forever even after a newer nightly shipped or the release was pulled (exactly what happened with the cleaned-up .220 draft).
Three new harness tests cover supersede / steady-state / revoked; gates green, desktop suites 23/23. Desktop state machine only, no UI markup changes.